Conversation
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Fixes #1437 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
A container's command line, as reported by podman, may comtain environment variables, which the current regexp (added in ed4fe58) does not support. Extend the regexp to allow environment variables and add an operational, config false, 'cmdline' leaf node to allow any characters to be reported for the full command line in the operational output. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
admin@gateway:~$ chronyc tracking Reference ID : C23ACD14 (svl1.ntp.netnod.se) Stratum : 2 Ref time (UTC) : Sun Apr 19 20:28:40 2026 System time : 0.000000000 seconds fast of NTP time Last offset : -17.822519302 seconds RMS offset : 17.822519302 seconds Frequency : 1064.750 ppm slow Residual freq : +0.581 ppm Skew : 0.794 ppm Root delay : 0.018065268 seconds Root dispersion : 0.000200240 seconds Update interval : 0.0 seconds Leap status : Normal vs admin@gateway:/> show ntp tracking Reference ID : 194.58.205.20 Stratum : 2 Ref time (UTC) : Sun Apr 19 20:28:40 2026 System time : 0.000000 seconds slow of NTP time Last offset : -17.822519302 seconds RMS offset : 17.822519302 seconds Frequency : 1064.750 ppm slow Residual freq : +0.581 ppm Skew : 0.794 ppm Root delay : 0.018065 seconds Root dispersion : 0.000188 seconds Update interval : 0.0 seconds Leap status : Normal Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Contributor
Author
|
@mattiaswal would be really great if you could review this, at your earliest convenience. Thank you in advance! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
show ntp trackingdisplayed a truncated Reference ID (e.g. 92.2 instead of 92.246.137.39). When chronyc's CSV -c output has an IPv4 address in the name field, the code was blindly truncating it to 4 chars to satisfy the YANG refid string {length "4"} constraint. IPv6 server addresses (which NTP represents as a 32-bit MD5 hash) are also handled correctlyshow containershowed no output when a container's command line contained environment variables, which the existing regexp rejected. Extend the regexp and add aconfig falseleafcmdlineto carry the actual operational command line usedmake aarch64_defconfig devenables passwordless root-login in the aarch64 build.make devis a quick way to build since actually proceeds to callmake allafter applying all snippets. See the Developer's Guide for more detailsChecklist
Tick relevant boxes, this PR is-a or has-a: